On Thursday 10 December 2009, Michael S. Tsirkin wrote: > The recent e1000 bug made the important of using > symbolic macros for pci config access clear for me. > So I started going over drivers and converting > to symbolic constants instead of hard-coded ones. > I did a large part until I run out of steam. > Maybe some brave soul will take up converting > the rest of them, or maybe I will: note that > when converting bridges one should be careful > to use bridge macros where appropriate.
Seeing as you're introducing a huge amount of churn, wouldn't it be better to come up with a sane abstraction for initializing the the PCI config data (c.f. pci_config_set_vendor_id)? Paul
