On 11/12/2013 06:44 PM, Wenchao Xia wrote:
> Nested structure is not supported now, so following define is not valid:
> { 'event': 'EVENT_C',
> 'data': { 'a': { 'a_a', 'str', 'a_b', 'str' }, 'b': 'int' }But what IS valid? You need to document this in docs/qapi-code-gen.txt at a bare minimum. This patch series is hard to review, and still has the RFC subject line. At this point, I think it's worth rebasing and resending what you have; even if it needs more review, it will at least get it to a state that is easier to review. > +++ b/scripts/qapi-event.py > @@ -0,0 +1,355 @@ > +# > +# QAPI event generator > +# > +# Copyright IBM, Corp. 2013 > +# > +# Authors: > +# Wenchao Xia <xiaw...@linux.vnet.ibm.com> > +# > +# This work is licensed under the terms of the GNU GPLv2. Can you please use GPLv2+ (that is, add the "or later" clause)? We already have GPLv2-only code, but I don't want to increase the size of that unfortunate license choice. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
