On Mon, 16 Dec 2013 00:04:18 +0100 Andreas Färber <afaer...@suse.de> wrote:
> Hi, > > Am 13.12.2013 22:42, schrieb Antony Pavlov: > > Also this patch adds initial support for Canon > > PowerShot A1100 IS compact camera. > > > > Signed-off-by: Antony Pavlov <antonynpav...@gmail.com> > > --- > > hw/arm/Makefile.objs | 1 + > > hw/arm/digic_boards.c | 84 > > +++++++++++++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 85 insertions(+) > > create mode 100644 hw/arm/digic_boards.c > > This patch is lacking a one-line addition to tests/qom-test.c to have > this new board actually covered by `make check`. Please add it here if > you respin or post a separate patch as follow-up. Do you mean this? --- a/tests/qom-test.c +++ b/tests/qom-test.c @@ -70,6 +70,7 @@ static const char *arm_machines[] = { "xilinx-zynq-a9", "highbank", "midway", + "canon-a1100", }; > PMM/PC: May apply to other recent series as well, please keep eyes open! > > Regards, > Andreas > > P.S. It would've been helpful to include a diffstat in the cover letter > as is done by default for --cover-letter. > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- -- Best regards, Antony Pavlov