On 01/06/2014 05:10 AM, Peter Maydell wrote: > Our float32 to float16 conversion routine was generating the correct > numerical answers, but not always setting the right set of exception > flags. Fix this, mostly by rearranging the code to more closely > resemble RoundAndPackFloat*, and in particular: > * non-IEEE halfprec always raises Invalid for input NaNs > * we need to check for the overflow case before underflow > * we weren't getting the tininess-detected-after-rounding > case correct (somewhat academic since only ARM uses halfprec > and it is always tininess-detected-before-rounding) > * non-IEEE halfprec overflow raises only Invalid, not > Invalid + Inexact > * we weren't setting Inexact when we should > > Also add some clarifying comments about what the code is doing. > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > fpu/softfloat.c | 105 > +++++++++++++++++++++++++++++++++++--------------------- > 1 file changed, 66 insertions(+), 39 deletions(-)
Reviewed-by: Richard Henderson <r...@twiddle.net> r~