On Thu, Jan 09, 2014 at 03:41:23PM +0100, Lluís Vilanova wrote: > diff --git a/trace/simple.c b/trace/simple.c > index 1e3f691..8b59760 100644 > --- a/trace/simple.c > +++ b/trace/simple.c > @@ -8,6 +8,8 @@ > * > */ > > +#include "trace/simple.h" > + > #include <stdlib.h> > #include <stdint.h> > #include <stdio.h>
Please put user-defined header #includes (<>) below system header #includes (""). This ensures we don't define macros that affect system headers.