Luiz Capitulino <lcapitul...@redhat.com> writes: > On Tue, 15 Dec 2009 10:54:23 +0100 > Markus Armbruster <arm...@redhat.com> wrote: > >> Markus Armbruster <arm...@redhat.com> writes: >> >> > Luiz Capitulino <lcapitul...@redhat.com> writes: >> > >> >> The monitor_read_command() function is readline specific >> >> and should only be used when readline is available. >> >> >> >> Signed-off-by: Luiz Capitulino <lcapitul...@redhat.com> >> > >> > I figure this bug breaks password entry (VNC and block) on non-readline >> > monitors. Suspect commit cde76ee1. > > I can only assume that it didn't matter until now. > >> PS: Subject is wrong. gdbserver_start() creates a monitor with >> MONITOR_USE_READLINE off, so it's not just QMP. > > Ditto.
Subject is wrong, because the commit avoids readline not only in QMP, but whenever the monitor is configured not to use readline. Yes, I'm nitpicking :)
