On 24 January 2014 19:08, Paolo Bonzini <paolo.bonz...@gmail.com> wrote: > For blizzard, pl110 and tc6393xb this is harmless, but for pxa2xx > Coverity noticed that it is used inside an "if" statement. > Fix it because it's the file with the highest number of defects > in the whole QEMU tree! Use "do...while(0)", or just remove the > semicolon if there's a single statement in the macro. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
checkpatch says: total: 29 errors, 0 warnings, 111 lines checked some of which are genuinely new with this patch. In general it's better to fix the nits if you're messing with the file anyway; could you do that, please? thanks -- PMM