Am 05.02.2014 18:55, schrieb Paolo Bonzini: > Il 05/02/2014 18:51, Andreas Färber ha scritto: >>> > So, even though I think this script is a very welcome addition, I >>> don't >>> > think it helps settling the question of what to do with "info qtree". >>> > IMO there's no good reason to exclude busless devices from "info >>> qtree", >>> > and it's a bug (of course less severe than crashing, but still a bug) >>> > that the busless nand device doesn't appear there. >> Don't you see that that is unfixable? We may be able to replace info >> qtree by an info qom-tree, which does the equivalent of this QMP-based >> script, but qtree ues a completely different display hierarchy than QOM. > > Yes, that's why it's useful. :) > > Busless devices can still be listed, either under their parent or as > siblings of the system bus.
info qtree has been inconclusive for - what? - two years now and no one has bothered to fix it. If you or Markus care about it, post a patch. :) The code uses qdev/qbus functions to list those devices so I don't see an easy way of filtering those devices that qdev/qbus missed and printing them using the same walking functions. Therefore my saying that we would need to walk the QOM hierarchy instead, which is output-incompatible with info qtree and thus a different command. Not to mention that it will not work for objects that are not devices. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
