On Sat, Dec 19, 2009 at 10:52:52AM -0800, Richard Henderson wrote: > Changes from round 3: > > * Drop movcond for now. > * Only use movzbl and not xor in setcond. > >
Thanks for the update, it looks like ready, I only have cosmetic or minor comments. See my comments in the individual patches I think we should commit it now, but wait a bit until it is implemented in all TCG targets to use this new ops. We can circulate patches in the meanwhile. > > > Richard Henderson (5): > tcg: Generic support for conditional set > tcg-x86_64: Implement setcond. > tcg-i386: Implement small forward branches. > tcg: Add tcg_invert_cond. > tcg-i386: Implement setcond. > > elf.h | 2 + > tcg/README | 20 +++++- > tcg/i386/tcg-target.c | 187 > +++++++++++++++++++++++++++++++++++++---------- > tcg/tcg-op.h | 47 ++++++++++++ > tcg/tcg-opc.h | 3 + > tcg/tcg.c | 21 ++++-- > tcg/tcg.h | 5 + > tcg/x86_64/tcg-target.c | 38 ++++++++- > 8 files changed, 271 insertions(+), 52 deletions(-) > > > > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurel...@aurel32.net http://www.aurel32.net
