On 02/16/2014 06:21 AM, Paolo Bonzini wrote:
> Il 31/01/2014 15:43, Richard Henderson ha scritto:
>> + gen_shift_maybe_vex:
>> + if (have_bmi2 && !const_args[2]) {
>> + tcg_out_vex_modrm(s, vexop + rexw, args[0], args[2], args[1]);
>> + break;
>> + }
>> + /* FALLTHRU */
>
> What if args[2] happens to be ECX?
shlx handles that just fine. I don't think it's worth an extra check to
fall back to shl on the off-chance that ecx is used; it's pretty far down
on the register allocation order list, so it wouldn't happen often.
r~
