On 02/17/2014 06:47 AM, Vincent KHERBACHE wrote: > The test (!!(mem->flags & KVM_MEM_LOG_DIRTY_PAGES) == enable) is not > good because the condition is valid when enable == 0 and current dirty log > memory flag is set. > As a consequence kvm_log_global_stop() does not stop the KVM dirty log > tracking: kvm_set_migration_log(0) didn't do its job. > So instead I propose to use kvm_slot_dirty_pages_log_change() which correctly > compare the memory flags (old/new). > > Signed-off-by: Vincent KHERBACHE <vincent.kherba...@inria.fr> > --- > kvm-all.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) >
> + err = kvm_slot_dirty_pages_log_change(mem, (bool)enable); Casting to bool looks odd. We already require a compliant C99 compiler, which means the compiler already properly handles the squashing of all non-zero values to true when calling a function with a parameter prototyped as bool, without needing the cast. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
