The Saturday 22 Feb 2014 à 15:38:15 (+0800), Fam Zheng wrote : > On Sat, 02/22 02:20, Benoît Canet wrote: > > Quorum is not compiled by default: make the quorum 081 test aware of this. > > > > Signed-off-by: Benoit Canet <ben...@irqsave.net> > > --- > > tests/qemu-iotests/081 | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/tests/qemu-iotests/081 b/tests/qemu-iotests/081 > > index f053f11..c1078f6 100755 > > --- a/tests/qemu-iotests/081 > > +++ b/tests/qemu-iotests/081 > > @@ -56,6 +56,9 @@ function run_qemu() > > do_run_qemu "$@" 2>&1 | _filter_testdir | _filter_qmp | _filter_qemu_io > > } > > > > +test_quorum=$(qemu-img --help|grep quorum) > > +[ "$test_quorum" = "" ] && _supported_fmt quorum > > + > > How does this disable the test? When quorum is not compiled, the two lines are > no-op. Did you test it?
Yes I did test it. It works. > > qemu-img should be $QEMU_IMG. > > I think you mean this: > > $QEMU_IMG --help | grep -q quorum && _not_run "quorum is not compiled" > > Thanks, > Fam