On 02/24/2014 10:11 AM, Peter Maydell wrote:
> On 24 February 2014 17:59, Richard Henderson <r...@twiddle.net> wrote:
>> I'll also note that arm contains a second copy of the aes_{i,}shifts arrays.
>> So after those are moved to common code, we avoid that duplication too.
>
> AIUI this duplication was because the utils/ code wasn't suitable
> for ARM; Ard's rationale is here:
> http://lists.gnu.org/archive/html/qemu-devel/2013-12/msg01789.html
That's about sbox vs AES_Te*.
In the bit you quote, I'm talking about aes_shift[] vs shift[0][] and
aes_ishift[] vs shift[1][], in the i386 and arm backends respectively. And
arguing that data should be moved to utils/ so that it can be shared between
i386, arm, and ppc.
In a bit you don't quote, I argue that arm's sbox array should be moved to
utils/ so that it can be shared with ppc, which will need it for its "vsbox"
instruction.
I don't really have an opinion on arm's MixColumns lookup table.
r~
