On 03/04/2014 07:00 AM, Paolo Bonzini wrote: > From: Hu Tao <hu...@cn.fujitsu.com> > > Add qmp command query-memdev to query for information > of memory devices > > Signed-off-by: Hu Tao <hu...@cn.fujitsu.com> > [Use QMP visitors instead of String visitors. - Paolo] > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > numa.c | 64 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > qapi-schema.json | 31 +++++++++++++++++++++++++++ > qmp-commands.hx | 32 ++++++++++++++++++++++++++++ > 3 files changed, 127 insertions(+) >
> +++ b/qapi-schema.json
> @@ -4576,3 +4576,34 @@
> ##
> { 'enum': 'HostMemPolicy',
> 'data': [ 'default', 'preferred', 'membind', 'interleave' ] }
> +
> +##
> +# @Memdev:
> +#
> +# Information of memory device
> +#
> +# @size: memory device size
> +#
> +# @host-nodes: host nodes for its memory policy
> +#
> +# @policy: memory policy of memory device
> +#
> +# Since: 2.1
> +##
> +
> +{ 'type': 'Memdev',
> + 'data': {
> + 'size': 'size',
> + 'host-nodes': ['uint16'],
> + 'policy': 'str' }}
Why is policy 'str', when you just defined 'HostMemPolicy' as an enum in
the previous patch? Should this be using the enum?
> +<- { "return": [
> + {
> + "size": 536870912,
> + "host-nodes": [0, 1],
> + "policy": "bind"
"bind" is not one of the values of HostMemPolicy - is that missing from
patch 27/28?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
