On Thu, Mar 06, 2014 at 12:47:28PM +0100, Paolo Bonzini wrote: > Il 06/03/2014 04:11, Alexey Kardashevskiy ha scritto: > >Previously libvirt required the first/default PCI bus to have name "pci". > >Since QEMU can support multiple buses now, libvirt wants "pci.0" now. > > > >This removes custom busname and lets QEMU make up default names. > > > >Signed-off-by: Alexey Kardashevskiy <[email protected]> > >--- > > > >I tested this with: > > -netdev > > tap,id=id0,ifname=tapqemu-tap-00,script=ifup.sh,downscript=ifdown.sh \ > > -device e1000,id=id1,netdev=id0,mac=C0:41:49:4b:00:00 \ > > -device \ > > spapr-pci-host-bridge,index=5,id=aikbus \ > > -netdev tap,id=id2,ifname=tap-1,script=ifup.sh,downscript=ifdown.sh \ > > -device rtl8139,id=id3,netdev=id2,bus=aikbus.0,mac=C0:41:49:4b:00:01 \ > > -device spapr-pci-vfio-host-bridge,id=id4,index=10,iommu=4 \ > > > >This creates a default PCI, an additional emulated PCI bus (named aikbus, > >if I omit the name, it is pci.1 which is also fine) and VFIO bus (which is > >not in upstream yet but still), this all works fine and I cannot see any > >flaw. > > Thanks! > > Andreas, are you taking this patch?
I'd like to see this change done across all machines, not just this ppc one, so that libvirt can do 1 single version check and know that the new naming applies for everything from that point. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
