qemu-img should use QMP commands whenever possible in order to ensure feature completeness of both online and offline image operations. For the "commit" command, this is relatively easy, so implement it first (in the hope that indeed others will follow).
As qemu-img does not have access to QMP (due to QMP being intertwined with basically everything in qemu), we cannot directly use QMP, but at least use the functions the corresponding QMP commands are using (which would be "block-commit", in this case). Max Reitz (4): block-commit: Expose granularity block-commit: speed is an optional parameter qemu-img: Implement commit like QMP qemu-img: Enable progress output for commit block/Makefile.objs | 2 +- block/commit.c | 16 ++++++-- block/mirror.c | 4 +- blockdev.c | 22 +++++++--- include/block/block_int.h | 6 ++- qapi-schema.json | 5 ++- qemu-img-cmds.hx | 4 +- qemu-img.c | 100 ++++++++++++++++++++++++++++++++++++---------- qemu-img.texi | 2 +- 9 files changed, 122 insertions(+), 39 deletions(-) -- 1.9.1
