On Wed, 16 Apr 2014 17:42:22 +0100 Peter Maydell <peter.mayd...@linaro.org> wrote:
> On 16 April 2014 17:34, Michael S. Tsirkin <m...@redhat.com> wrote: > > so it looks like virtio is currently compiled per-target. > > So why isn't it reasonable to keep it per-target for > > purpose of this enhancement? > > What am I missing? > > "virtio" is more than one C file. Currently per-target: > hw/virtio/virtio.c > hw/virtio/virtio-balloon.c > hw/scsi/virtio-scsi.c > hw/block/virtio-blk.c > hw/char/virtio-serial-bus.c > hw/net/virtio-net.c > > Currently built once: > hw/char/virtio-console.c > hw/virtio/virtio-bus.c > hw/virtio/virtio-mmio.c > hw/virtio/virtio-pci.c > hw/virtio/virtio-rng.c > > If we can move files from the first group to the second > that's cool. Moving files from the second to the first is > what I'd like to avoid... > > thanks > -- PMM > I had got at a point where I could move nearly all the code to common-obj, and the cool benefits distracted me from that unwanted branch for fixed endian targets... Sorry for the confusion and noise. :) -- Gregory Kurz kurzg...@fr.ibm.com gk...@linux.vnet.ibm.com Software Engineer @ IBM/Meiosys http://www.ibm.com Tel +33 (0)562 165 496 "Anarchy is about taking complete responsibility for yourself." Alan Moore.