On Thu, Jan 07, 2010 at 12:15:25PM +0100, Stefan Weil wrote: > The numerical value was wrong (0x2800 instead of 0x0280) > which indeed did not make sense.
Aha! conversion to symbolic names paying off. > Signed-off-by: Stefan Weil <w...@mail.berlios.de> Applied, thanks. > --- > hw/eepro100.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/hw/eepro100.c b/hw/eepro100.c > index 336ca49..a21c984 100644 > --- a/hw/eepro100.c > +++ b/hw/eepro100.c > @@ -420,10 +420,8 @@ static void pci_reset(EEPRO100State * s) > /* TODO: this is the default, do not override. */ > PCI_CONFIG_16(PCI_COMMAND, 0x0000); > /* PCI Status */ > - /* TODO: this seems to make no sense. */ > /* TODO: Value at RST# should be 0. */ So this second todo can go too. I've removed it in my tree. > - PCI_CONFIG_16(PCI_STATUS, > - PCI_STATUS_REC_MASTER_ABORT | PCI_STATUS_SIG_TARGET_ABORT); > + PCI_CONFIG_16(PCI_STATUS, PCI_STATUS_DEVSEL_MEDIUM | > PCI_STATUS_FAST_BACK); > /* PCI Revision ID */ > PCI_CONFIG_8(PCI_REVISION_ID, 0x08); BTW if you are not afraid of churn, there's no reason for PCI_CONFIG_8 and friends anymore, because pci.h has much nicer pci_set_byte etc. > /* TODO: this is the default, do not override. */ > -- > 1.6.5