On 26 April 2014 11:44, Amos Kong <ak...@redhat.com> wrote: > > I'm ok with the patch idea. > > On Sat, Apr 26, 2014 at 06:19:12PM +0800, zhanghailiang wrote: >> For e1000/rtl8139, qemu can still send/receive packets when VM is paused. > ^^^^^^^^^ > -> isn't running > > There are many kinds of RunState, "is paused" doesn't equal to "isn't > running". > >> If this happened in *migration's* last PAUSE VM stage, the new dirty RAM >> related to the packets will be missed. >> To avoid this, do things like virtio-net, forbid sending/receiving >> packets when VM is suspend. > ^^^^^^^^^^^ -> isn't running.
Shouldn't this be handled in the generic net code rather than requiring every ethernet device model to include identical code? thanks -- PMM