On Sun, May 04, 2014 at 07:51:40PM +0800, Fam Zheng wrote:
> On Thu, 05/01 16:54, Stefan Hajnoczi wrote:
> > +    VirtIOBlockRequest *req = g_slice_new(VirtIOBlockRequest);
> 
> Could be g_slice_new0,
> 
> > +    QEMUIOVector *qiov;
> > +    int nb_sectors;
> > +
> > +    /* Fill in virtio block metadata needed for completion */
> > +    memset(req, 0, sizeof(*req));
> 
> so this memset is not needed.

Thanks, will fix.

Reply via email to