On 01/11/2010 02:40 PM, Jan Kiszka wrote:
Anthony Liguori wrote:
On 01/07/2010 10:24 AM, Gleb Natapov wrote:
diff --git a/target-i386/kvm.c b/target-i386/kvm.c
index 4084503..6a841de 100644
--- a/target-i386/kvm.c
+++ b/target-i386/kvm.c
@@ -17,6 +17,7 @@
   #include<sys/mman.h>

   #include<linux/kvm.h>
+#include<linux/kvm_para.h>
This breaks the build on a default F12 install because while kvm.h is
present, kvm_para.h is not.  This is a hard one to fix.

We can default the kvm search path to /lib/modules/$(uname -r)/build, we
can fix the glibc headers and live with it, or we can pull in the kvm
headers into qemu.

Avi/Marcelo/Jan, any thoughts from the qemu-kvm side?
kvm-kmod-wise, I can include arch and generic kvm_para.h in the next
release (missed the need for it so far). I'm planning to write a qemu
patch to ask pkg-config for kvm-kmod headers.

That would be nice.

I assume a change has to be made in the kernel too so that the libc headers are updated. IOW, I assume make headers_install doesn't currently install kvm_para.h

If we can live with considering the cpuid leaf a feature that depends on
a recent kvm-kmod version and is disabled otherwise, we are done. If
not, tricks like the above are required.

It's less than ideal, but I can live with it.

Regards,

Anthony Liguori

Jan




Reply via email to