On Mon, May 12, 2014 at 08:57:30PM -0600, Eric Blake wrote: > On 05/07/2014 07:14 PM, Amos Kong wrote: > > The space before pointers is redundant. > > > > Signed-off-by: Amos Kong <ak...@redhat.com> > > --- > > scripts/qapi-visit.py | 20 ++++++++++---------- > > 1 file changed, 10 insertions(+), 10 deletions(-) > > <rant> > Appears to be unchanged from v2. Missing the Reviewed-by I gave on v2 > for the code, and you were even reminded about that in v3. I suggested > a better wording for the commit message in v2: > > A space after * when declaring a pointer type is redundant. > > but that still hasn't been done. It's frustrating when review comments > are not addressed (even if you don't want to make a particular change, > at least document why keeping things unchanged is preferable, rather > than silently ignoring the review). > </rant>
Sorry about the careless. > That said, the change is still correct, so it still deserves: > > Reviewed-by: Eric Blake <ebl...@redhat.com> Thanks for your patience of the new review-by. > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org -- Amos.
pgpQvy3dAL3lL.pgp
Description: PGP signature
