On 27.05.14 12:37, Alexey Kardashevskiy wrote:
This adds spr_write_ureg() helper and uses it for UPMCx and MMCR0 SPRs.Signed-off-by: Alexey Kardashevskiy <a...@ozlabs.ru> --- target-ppc/translate_init.c | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index 88acf70..595fd3f 100644 --- a/target-ppc/translate_init.c +++ b/target-ppc/translate_init.c @@ -175,6 +175,11 @@ static void spr_read_ureg (void *opaque, int gprn, int sprn) gen_load_spr(cpu_gpr[gprn], sprn + 0x10); }+static void spr_write_ureg(void *opaque, int gprn, int sprn)+{ + gen_store_spr(sprn + 0x10, cpu_gpr[gprn]); +} + /* SPR common to all non-embedded PowerPC */ /* DECR */ #if !defined(CONFIG_USER_ONLY) @@ -7379,28 +7384,28 @@ static void gen_spr_book3s_pmu(CPUPPCState *env) &spr_read_generic, SPR_NOACCESS, 0x00000000); spr_register(env, SPR_POWER_UMMCR0, "UMMCR0", - &spr_read_ureg, SPR_NOACCESS, - &spr_read_ureg, SPR_NOACCESS, + &spr_read_ureg, &spr_write_ureg, + &spr_read_ureg, &spr_write_ureg,
Are you sure about this? The 970MP spec says "Performance Monitor Registers (For Reading)". In general, I don't think we would ever really have an spr_write_ureg user.
Alex
