On Fri, 30 May 2014 13:17:44 +0200 Stefan Hajnoczi <stefa...@redhat.com> wrote:
> Move the x-data-plane property. Originally it was outside since not > every transport may wish to support dataplane. But that makes little > sense when we have a dedicated CONFIG_VIRTIO_BLK_DATA_PLANE ifdef > already. This would add a x-data-plane property to s390-virtio devices, which leads to insta-death if enabled since s390-virtio devices don't have guest notifiers, no? Just an observation; in general, moving the property makes sense to me. > > This move makes it easier to switch to property aliases in the next > patch. > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > Reviewed-by: Peter Crosthwaite <peter.crosthwa...@xilinx.com> > --- > hw/s390x/virtio-ccw.c | 3 --- > hw/virtio/virtio-pci.c | 3 --- > include/hw/virtio/virtio-blk.h | 8 ++++++++ > 3 files changed, 8 insertions(+), 6 deletions(-) >