On 7 June 2014 00:22, Igor Mammedov <imamm...@redhat.com> wrote: > Eduardo Habkost <ehabk...@redhat.com> wrote: >> On Fri, Jun 06, 2014 at 11:38:58PM +0200, Igor Mammedov wrote: >> > Eduardo Habkost <ehabk...@redhat.com> wrote: >> > > $ ./install/bin/qemu-system-x86_64 -global cpu.foobar=5 >> > > qemu-system-x86_64: Property '.foobar' not found >> > > Aborted (core dumped) >> > That is expected behavior. >> >> Why? >> >> QEMU should never dump core due to user error. >> >> QEMU should not abort when handling a device_add command due to user >> error. > I've meant QEMU shouldn't start if CLI has error. whether it's abort or > exit(FAIL) doesn't matter much.
I'm with Eduardo on this one -- if the user passes us a bad command line we should diagnose it helpfully and exit with a failure code; abort() is for programming errors. (If nothing else, using abort() for user-triggerable conditions tends to mean we get bug reports about core dumps, so it's in our own interest to not do that :-) ) thanks -- PMM
