Il 10/06/2014 09:29, Stefan Hajnoczi ha scritto:
This series adds blockstats support to virtio-blk data-plane and protects
query-blockstats from races with the dataplane IOThread.

Stefan Hajnoczi (3):
  dataplane: add bdrv_acct_*() accounting
  block: make bdrv_query_stats() static
  block: acquire AioContext is qmp_query_blockstats()

 block/qapi.c                    |  6 +++++-
 hw/block/dataplane/virtio-blk.c | 10 ++++++++++
 include/block/qapi.h            |  1 -
 3 files changed, 15 insertions(+), 2 deletions(-)


ACK to patches 2 and 3.

Regarding patch 1 it's nice that the change is so trivial so I'm not objecting to the patch.

However, Fam's patches for VirtIOBlockReq{,uest} unification provide another way to achieve this. If we could drop do_rdwr_cmd in favor of virtio_blk_handle_read and virtio_blk_handle_write, we would get for free both blockstats and rerror/werror support. What do you think?

Paolo

Reply via email to