On 06/17/2014 12:45 PM, Peter Maydell wrote: > On 17 June 2014 19:39, Eric Blake <ebl...@redhat.com> wrote: >> On 06/17/2014 11:36 AM, Michael S. Tsirkin wrote: >>> From: Igor Mammedov <imamm...@redhat.com> >>> >>> using the same memdev backend more than once will cause >>> assersion at MemoryRegion mapping time becase it's already >> >> s/assersion/assertion/; s/becase/because/ >> (but probably too late now that this is a pull request) > > Incidentally, if anybody notices something that should > mean a pull request ought not to be applied, they need > to send an email which is a followup to the cover letter. > Otherwise there's no guarantee I'll notice it when I'm > processing the pullreq.
Got it. So far, all that I've pointed out can be done as followups (typos in code) or ignored as too late (typos in commit message) - I haven't found anything that should prevent this pull request from actually going in. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature