On 30 June 2014 11:23, Gerd Hoffmann <kra...@redhat.com> wrote: > Hi, > >> > * The old qemu_chr_open_socket() has an >> > "if (!is_waitconnect) >> > qemu_set_nonblock(fd); >> > which the QMP char-open codepath has never had. Does this matter? >> > Which of the two code paths was correct? >> >> Gerd? > > IIRC the socket is put into non-blocking mode anyway by the qemu socket > helper functions.
In that case is qemu_chr_open_socket_fd() incorrect in marking the socket as nonblocking in the is_listen && is_waitconnect case? -- PMM
