On 07/15/2014 06:19 AM, Bastian Koppelmann wrote: > >>> + tcg_gen_addi_tl(cpu_gpr_d[r1], cpu_gpr_d[r1], const4); >> Are you planning to come back to implement V and AV bits later? > Would you recommend implementing this as a helper? It seems rather complex. > Especially with half-word and byte arithmetic. On the other hand the > instructions using this are common and would benefit from open-coding it in > TCG.
The halfword and byte insns probably require a helper. It's certainly going to be worth while open coding the full word operations. Ideally we'd be able to use vector instructions on the host, but we'd need serious enhancements to TCG in order to implement that. When the implementation of an insn requires more than, say, a dozen insns, or requires any branching at all, then I believe we're better off sharing the code with a helper. This is because the real compiler is significantly better than TCG at generating code across basic blocks, and the reduction in icache usage. r~
