On Thu, 2014-07-17 at 17:55 +0100, Peter Maydell wrote: > On 29 June 2014 10:09, Marcel Apfelbaum <marce...@redhat.com> wrote: > > Replaced '_' with '-' to comply with QOM guidelines. > > Made the conversion from HMP to QMP in vl.c > > > > Signed-off-by: Marcel Apfelbaum <marce...@redhat.com> > > > index a1686ef..7587c97 100644 > > --- a/vl.c > > +++ b/vl.c > > @@ -2820,15 +2820,25 @@ static int object_set_property(const char *name, > > const char *value, void *opaque > > Object *obj = OBJECT(opaque); > > StringInputVisitor *siv; > > Error *local_err = NULL; > > + char *c, *qom_name; > > > > if (strcmp(name, "qom-type") == 0 || strcmp(name, "id") == 0 || > > strcmp(name, "type") == 0) { > > return 0; > > } > > > > + qom_name = g_strdup(name); > > Memory allocated with g_strdup... > > > + c = qom_name; > > + while (*c++) { > > + if (*c == '_') { > > + *c = '-'; > > + } > > + } > > + > > siv = string_input_visitor_new(value); > > - object_property_set(obj, string_input_get_visitor(siv), name, > > &local_err); > > + object_property_set(obj, string_input_get_visitor(siv), qom_name, > > &local_err); > > string_input_visitor_cleanup(siv); > > + free(qom_name); > > ...but freed with free rather than g_free. Thanks, I'll take care of that. Marcel
> > > > > if (local_err) { > > qerror_report_err(local_err); > > -- > > 1.8.3.1 > > thanks > -- PMM