On Mon, 8 Feb 2010, Paolo Bonzini wrote: > malc, > > commit bc5b600 does the same thing as the series I posted at > http://permalink.gmane.org/gmane.comp.emulators.qemu/62997, only worse: > > 1) for vl.c and qemu-img.c, it disable FORTIFY_SOURCE checking which is only > enabled by the printf macro: > > # define printf(...) \ > __builtin___printf_chk (__USE_FORTIFY_LEVEL - 1, __VA_ARGS__) > > 2) for readline.c, it includes a useless complication, namely > > #ifdef printf > #undef printf > #endif > > 3) for vl.c, it doesn't take the occasion to cleanup qemu-options.hx's useless > usage of % sequences that are filled in by vl.c. > > Please revert it and commit my series instead, or explain why you didn't care > about reading the entire thread or about explicitly NACKing my patches.
Because i had a hard disk crash and hence ended up with a new shiny system where QEMU does not build anymore, also not enough patience to revisit the thread and figure out why it wasn't applied yet. -- mailto:av1...@comtv.ru