On (Mon) 04 Aug 2014 [13:33:56], Markus Armbruster wrote: > Amit Shah <amit.s...@redhat.com> writes: > > > To ensure two virtserialports don't get added to the system with the > > same 'name' parameter, we need to access all the ports on all the > > devices added, and compare the names. > > > > We currently don't have a list of all VirtIOSerial devices added to the > > system. This commit adds a simple linked list in which devices are put > > when they're initialized, and removed when they go away.
<snip> > > +struct VirtIOSerialDevices { > > + QLIST_HEAD(, VirtIOSerial) devices; > > +} vserdevices; > > + > > Any particular reason for stuffing the list into a struct? Not strictly needed for this patch alone, but I think it's cleaner to keep it this way, and when something else comes up that needs a per-device variable, this list will be around. Also, this is also the way it's done in the kernel, so that uniformity helps as well. <snip> > Patch looks simple & safe to me, but I can't help to wonder whether want > (or already have?) more generic infrastructure offering "for all devices > of a certain kind" functionality, which is what 2/2 needs. Andreas? Yea; I didn't find any, but if there's already something it can be put to good use here. Thanks, Amit