From: Chen Gang <gang.chen.5...@gmail.com> getchar() is a standard c library function which may return with failure (e.g. -1), so like another platforms, also need check it under WIN32.
And make the related code match current qemu code styles, too. Signed-off-by: Chen Gang <gang.chen.5...@gmail.com> Signed-off-by: Michael Tokarev <m...@tls.msk.ru> --- qemu-img.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index d4518e7..19495bb 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -185,15 +185,20 @@ static int GCC_FMT_ATTR(2, 3) qprintf(bool quiet, const char *fmt, ...) static int read_password(char *buf, int buf_size) { int c, i; + printf("Password: "); fflush(stdout); i = 0; for(;;) { c = getchar(); - if (c == '\n') + if (c < 0) { + buf[i] = '\0'; + return -1; + } else if (c == '\n') { break; - if (i < (buf_size - 1)) + } else if (i < (buf_size - 1)) { buf[i++] = c; + } } buf[i] = '\0'; return 0; -- 1.7.10.4