On Mon, Aug 11, 2014 at 05:34:19PM +0800, arei.gong...@huawei.com wrote: > From: Gonglei <arei.gong...@huawei.com> > > Technically, fcntl(soc, F_SETFL, O_NONBLOCK) > is incorrect since it clobbers all other file flags. > We can use F_GETFL to get the current flags, set or > clear the O_NONBLOCK flag, then use F_SETFL to set the flags. > > Using the qemu_set_nonblock() wrapper. > > BTW, qemu_set_nonblock() locate qemu/socket.h, some other files > can not call it, such as tap-linux.c, maybe we can consider > pulling it out. Any ideas? Thanks. > > Gonglei (2): > qemu-char: using qemu_set_nonblock() instead of fcntl(O_NONBLOCK) > channel-posix: using qemu_set_nonblock() instead of fcntl(O_NONBLOCK) > > qemu-char.c | 4 ++-- > qga/channel-posix.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-)
More of a chardev series but trivial and I've reviewed it. Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan
pgpQezOG8g_cE.pgp
Description: PGP signature
