Knut Omang <knut.om...@oracle.com> writes: > On Mon, 2014-08-25 at 11:48 +0200, Markus Armbruster wrote: >> <arei.gong...@huawei.com> writes: >> >> > From: Gonglei <arei.gong...@huawei.com> >> > >> > Signed-off-by: Gonglei <arei.gong...@huawei.com> >> > --- >> > hw/pci-bridge/ioh3420.h | 4 ---- >> > 1 file changed, 4 deletions(-) >> > >> > diff --git a/hw/pci-bridge/ioh3420.h b/hw/pci-bridge/ioh3420.h >> > index 7776e5b..ea423cb 100644 >> > --- a/hw/pci-bridge/ioh3420.h >> > +++ b/hw/pci-bridge/ioh3420.h >> > @@ -3,8 +3,4 @@ >> > >> > #include "hw/pci/pcie_port.h" >> > >> > -PCIESlot *ioh3420_init(PCIBus *bus, int devfn, bool multifunction, >> > - const char *bus_name, pci_map_irq_fn map_irq, >> > - uint8_t port, uint8_t chassis, uint16_t slot); >> > - >> > #endif /* QEMU_IOH3420_H */ >> >> Breaks the build >> >> qemu/hw/pci-bridge/ioh3420.c:159:11: warning: no previous >> prototype for ‘ioh3420_init’ [-Wmissing-prototypes] >> >> because it removes the prototype of an unused function. Keep both for >> future use, or remove both. > > Michael just pulled in my patch > ([PULL 09/11] ioh3420: Remove obsoleted, unused ioh3420_init function) > > which removed the definition as a result of the review feedback, > unfortunately I overlooked the declaration in the header file. > > Again, sorry for the confusion,
Gonglei, please make sure to state patch prerequisites. In this case, you should've pointed to Knut's patch in the commit message.