On Thu, Aug 07, 2014 at 12:18:47PM +0200, Paolo Bonzini wrote:
> Il 07/08/2014 04:24, Amos Kong ha scritto:
> > Eduardo, a similar patch had been applied.
> >
> > commit 5e490b6a504912225dff0e520e1c6af68295d238
> > Author: Amos Kong <ak...@redhat.com>
> > Date: Thu Nov 21 16:42:50 2013 +0800
> >
> > rng-egd: remove redundant free
> >
> > We didn't set default chr_name, the free is redundant.
> >
> > Signed-off-by: Amos Kong <ak...@redhat.com>
> > Message-id: 1385023371-8198-2-git-send-email-ak...@redhat.com
> > Signed-off-by: Anthony Liguori <aligu...@amazon.com>
> >
>
> What if you set chr_name twice?
In this case, g_free() is necessary.
So I'm fine with Eduardo's patch: [PATCH RESEND 1/2] rng-egd: Free old chr_name
value
> Paolo
--
Amos.
