On Tue, Aug 12, 2014 at 01:53:33PM -0500, Tom Musta wrote: > When the ipc system call is used to wrap a semctl system call, > the ptr argument to ipc needs to be dereferenced prior to passing > it to the semctl handler. This is because the fourth argument to > semctl is a union and not a pointer to a union. > > Signed-off-by: Tom Musta <tommu...@gmail.com> > --- > > V2: This is unchanged from V1. I briefly reviewew the QEMU, glibc and > kernel code > looking for some problems but did not find anything. I also did fairly > comprehesive > testing of semctl on 4 targets (ppc-linux-user, ppc64-linux-user, > ppc64le-linux-user, > x86_64-linux-user) on 3 different host platforms (x86-64 Ubuntu, PPC64 RHEL 6 > (BE) and > PPC64 Ubuntu 14.04 (LE)); this provided a broad coverage of co-endian and > cross endian > situations.
Reviewed-by: David Gibson <da...@gibson.dropbear.id.au> -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
pgpBzUJm4ymiL.pgp
Description: PGP signature