On 08/28/2014 06:31 AM, Stefan Hajnoczi wrote: > On Wed, Aug 27, 2014 at 07:33:13AM -0600, Eric Blake wrote: >> buf-size has the same bug a few lines later; might as well fix both at once. > > Hmm...which git tree are you looking at?
Serves me right for going off of a 'git grep' rather than actually looking at the source. > > I don't see any error paths for buf_size: > http://git.qemu-project.org/?p=qemu.git;a=blob;f=blockdev.c;h=6a204c662d4b648c78a379f5b8e8120254dde479;hb=HEAD#l2140 I _knew_ I had seen two violations: blockdev.c:2175: error_set(errp, QERR_INVALID_PARAMETER, device); blockdev.c:2179: error_set(errp, QERR_INVALID_PARAMETER, device); but based on that grep, I then _assumed_ that it was for two variables (hence my claim of granularity vs. buf_size). But as your patch fixes both violations, both related to "granularity", you are correct. Sorry for spreading confusion. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
