On 05.09.14 12:36, Peter Maydell wrote: > On 4 September 2014 23:17, Alexander Graf <ag...@suse.de> wrote: >> Peter, please pull the same tag name again - I updated it with the now >> working state. > > Doesn't build on Windows: > > hw/ppc/spapr.o: In function `spapr_populate_memory': > /home/petmay01/linaro/qemu-for-merges/hw/ppc/spapr.c:708: undefined > reference to `_ffsl' > /home/petmay01/linaro/qemu-for-merges/hw/ppc/spapr.c:708: undefined > reference to `_ffsl' > /home/petmay01/linaro/qemu-for-merges/hw/ppc/spapr.c:709: undefined > reference to `_ffsl' > > Don't try to use ffs() or ffsl() -- use the ctz32(), > ctz64() or ctzl() functions in host-utils.h (whichever > is appropriate for the size of the type; in this > case ctz64 I think). Watch out that in the common > case ctzl(x) == ffsl(x) - 1, and check the handling > of the edge case of zero input is what you want.
I've squashed Alexey's fix into the offending commit and rewrote the tag. Hopefully everything works out this time. Alex
