Am 17.09.2014 um 13:49 hat Benoît Canet geschrieben: > > > > +int qemu_opts_id_wellformed(const char *id) > > This return 0 and 1 as a bool. > Could we make the function return bool in the same series ?
I considered the change (as you probably saw, the new block.c function returns a bool), but then thought it wasn't important enough. In any case, that would be something for a separate patch. If you think it's important, I can send one. > I wonder what are the possible interferences between !strchr("-._", id[i]) > and Jeff's node name auto naming series. We might need to update the code then, but it would actually be a good reason why auto-naming wouldn't hurt if it uses characters that you can't use manually. Kevin