On 17 September 2014 08:55, Andreas Färber <afaer...@suse.de> wrote: > IIRC each machine is responsible for registering a reset hook that calls > - in most cases - cpu_reset(). > > The thing to look out for here is, does any machine already register a > reset hook and would reset twice with this patch?
Probably not -- any such double-reset would already be happening if the user passed -kernel. So in that sense this patch won't break things, but I wasn't sure if it's the right direction to go -- should we be fixing all the board and/or SoC models to do the CPU reset instead? QOM devices get reset when their bus gets reset, right? (so everything on a bus gets reset eventually as part of the process that starts when the top level sysbus gets reset). > What's the issue with v7-M? Probably also broken, but IIRC we don't actually wire up the register that's supposed to trigger a system reset... -- PMM
