On 18 September 2014 23:54, Markus Armbruster <arm...@redhat.com> wrote: > I think we should remove the whole thing: pcmcia_sockets, > pcmcia_socket_register(), pcmcia_socket_unregister, pcmcia_info(). > Here's why. > > It serves just one purpose: "info pcmcia". HMP-only, therefore not a > stable interface. But is it a useful one? > > The only caller of pcmcia_socket_register() is pxa2xx_pcmcia_realize(), > of device model "pxa2xx-pcmcia". As far as I can tell, used only by a > couple of ARM boards: "verdex", "mainstone", "akita", "spitz", "borzoi", > "terrier", "z2", "connex", "tosa". > > Of these, only "akita", "spitz", "borzoi", "terrier" and "tosa" insert a > card into the slot, and they do so right on board initialization. > Nothing ever ejects a card from a slot. Therefore, "info pcmcia" > effectively prints a fixed, machine-specific string so far. Doesn't > sound useful to me. > > If we acquire PCMCIA devices where querying status is interesting, we'll > want a QMP command, so this code will be pretty much useless.
I wouldn't particularly object to the info code disappearing. pxa2xx is pretty old and crufty code at this point and I don't suppose the pcmcia code has been modernised very much. (Couldn't you implement a hypothetical pcmcia HMP/QMP command by scanning the QOM tree for pcmcia device objects now anyway?) -- PMM
