Il 24/09/2014 13:48, Igor Mammedov ha scritto: > Drop useless hack that disables hotplug on bus, after backend > storage was added to it, by setting "allow_hotplug = 0". Even > if bus is hotpluggable, It won't be possible to add another > SCSI device to bus since its realize will fail early with > error "no free target" in scsi_qdev_realize() method. > > Signed-off-by: Igor Mammedov <imamm...@redhat.com> > --- > hw/usb/dev-storage.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c > index 4ad4ec7..b168d7c 100644 > --- a/hw/usb/dev-storage.c > +++ b/hw/usb/dev-storage.c > @@ -632,7 +632,6 @@ static void usb_msd_realize_storage(USBDevice *dev, Error > **errp) > error_propagate(errp, err); > return; > } > - s->bus.qbus.allow_hotplug = 0; > usb_msd_handle_reset(dev); > > if (bdrv_key_required(bs)) { >
Reviewed-by: Paolo Bonzini <pbonz...@redhat.com>