On Mon, Sep 22, 2014 at 04:44:51PM +0200, Gerd Hoffmann wrote: > From: Benjamin Herrenschmidt <b...@kernel.crashing.org> > > Provide different functions for converting from an LE vs a BE > framebuffer. We cannot rely on the simple cases always being > shared surfaces since cirrus will need to always shadow for > cursor emulation, so we need the full set of functions to > be able to later handle runtime switching.
[snip]
> > @@ -1572,19 +1585,19 @@ static void vga_draw_graphic(VGACommonState *s, int
> > full_update)
> bits = 8;
> break;
> case 15:
> - v = VGA_DRAW_LINE15;
> - bits = 16;
> + v = big_endian_fb ? VGA_DRAW_LINE15_BE : VGA_DRAW_LINE15_LE;
> + bits = 15;
> break;
> case 16:
> - v = VGA_DRAW_LINE16;
> - bits = 16;
> + v = big_endian_fb ? VGA_DRAW_LINE16_BE : VGA_DRAW_LINE16_LE;
> + bits = 15;
Is the change from bits=16 to bits=15 correct in this case?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgpbkpFdEEs3T.pgp
Description: PGP signature
