<arei.gong...@huawei.com> writes: > From: Gonglei <arei.gong...@huawei.com> > > When scsi_bus_legacy_add_drive() produces an error, > we will lose the error message. Using qerror_report_err > to report it because it is an HMP-only command. > > Cc: Markus Armbruster <arm...@redhat.com> > Cc: Paolo Bonzini <pbonz...@redhat.com> > Signed-off-by: Gonglei <arei.gong...@huawei.com> > Reviewed-by: Markus Armbruster <arm...@redhat.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> > --- > v5: > using qerror_report_err instead of error_report for an > HMP-only command (Paolo) > v4: > fix typo in the subject (Eric), Thanks. > v3: > fix some typos/grammar issues (Eric) and add 'R-by' tag > v2: > using original condition instead of local_err (Markus)
I liked v4 better. See my reply there for my reasons.