Cornelia Huck <[email protected]> writes: > On Tue, 30 Sep 2014 14:10:38 +0800 > <[email protected]> wrote: > >> From: Gonglei <[email protected]> >> >> For better code sharing, add a wrapper help funciton > > typo: s/funciton/function/ > >> for various virtio devices. > > s/for various virtio devices/that handles referencing the virtio > backend for virtio proxy devices/ ? > >> >> Cc: Cornelia Huck <[email protected]> >> Cc: Michael S. Tsirkin <[email protected]> >> Signed-off-by: Gonglei <[email protected]> >> --- >> hw/s390x/s390-virtio-bus.c | 42 +++++++++++++++++---------------------- >> hw/s390x/virtio-ccw.c | 42 +++++++++++++++++---------------------- >> hw/virtio/virtio-pci.c | 49 >> ++++++++++++++++++++-------------------------- >> hw/virtio/virtio.c | 11 +++++++++++ >> include/hw/virtio/virtio.h | 3 +++ >> 5 files changed, 71 insertions(+), 76 deletions(-) > > I'm wondering whether we should call the wrapper for virtio-balloon as > well. Even if it does not have any properties to alias, calling > qdev_alias_all_properties() probably doesn't hurt, does it? > > Looks good to me otherwise.
I didn't follow this, pardon me if I babble nonsense: could the hackery that creates usb-storage's implied scsi-disk profit from this mechanism? Start reading at usb_msd_realize_storage().
