On 22.10.2014 14:39, Zhang Haoyu wrote:
Use local variable to bdrv_pwrite_sync L1 table, needless to make conversion of cached L1 table between big-endian and host style.Signed-off-by: Zhang Haoyu <zhan...@sangfor.com> Reviewed-by: Max Reitz <mre...@redhat.com> --- v4 -> v5: - delete superfluous check of "l1_size2 != 0" after qemu_try_blockalign(l1_size2) v3 -> v4: - convert local L1 table to host-style before copy it back to s->l1_table v2 -> v3: - replace g_try_malloc0 with qemu_try_blockalign - copy the latest local L1 table back to s->l1_table after successfully bdrv_pwrite_sync L1 table v1 -> v2: - remove the superflous assignment, l1_table = NULL; - replace 512 with BDRV_SECTOR_SIZE, and align_offset with ROUND_UP - remove needless check of if (l1_table) before g_free(l1_table) block/qcow2-refcount.c | 28 ++++++++++++---------------- 1 file changed, 12 insertions(+), 16 deletions(-)
Sorry, but this patch breaks the qemu-iotests 060 and 061. I'll have a look into it myself, but for now I had to drop it from my block tree.
Max
