On Sun, Oct 26, 2014 at 06:55:21PM +0800, Gonglei wrote: > On 2014/10/26 18:48, Richard W.M. Jones wrote: > > > On Sun, Oct 26, 2014 at 06:45:02PM +0800, Gonglei wrote: > >> On 2014/10/26 18:22, Richard W.M. Jones wrote: > >> > >>> It's just there to stop unreasonable timeouts or negative numbers. > >>> 100000 s is 27 hours, and no webserver I know of would keep a > >>> connection open that long. Possibly not even the IP stack. > >>> > >> > >> Yes, it is. But 26 hours is OK? I just think we should assure the timeout > >> as reasonable range, absolutely 100000 is too big IMO. > >> > >>> What's the difference between defining a number at the top of the file > >>> to be used once, and placing it exactly where it is used? Except the > >>> former introduces long range dependencies into the code making it > >>> harder to read and more fragile when changed. > >> > >> > >> That's the purpose using macro. If this value is used only one place in > >> the > >> curl.c (or other c files) now and future, you are fine with it. :) > > > > I don't understand this part. Can you explain how you think a macro > > should be used? > > > > Sorry for misapprehension. I mean that's the purpose using macro what your > said: > " Except the former introduces long range dependencies into the code making it > harder to read and more fragile when changed."
OK, so our coding style is about introducing fragility and long range dependencies. v2 coming up ... Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v
