On Thu, Mar 04, 2010 at 05:59:11PM +0530, Amit Shah wrote: > On (Thu) Mar 04 2010 [14:19:58], Michael S. Tsirkin wrote: > > On Thu, Mar 04, 2010 at 05:50:19PM +0530, Amit Shah wrote: > > > On (Wed) Mar 03 2010 [19:16:28], Michael S. Tsirkin wrote: > > > > make it possible to use type without header include > > > > > > Why? > > > > So that vhost.h does not need to include virtio.h > > But what's the benefit in doing that?
Simpler dependencies. E.g. tap calls vhost init/cleanup but we do not want it to include virtio.h An alternative would be to split init/cleanup (does not need virtio), and start/stop (needs virtio). But typedef in qemu-common is already used for everything else. > Either way, a better commit msg would help. ok > Amit