On 2014-10-29 at 11:42, Stefan Hajnoczi wrote:
On Mon, Oct 27, 2014 at 01:30:07PM +0100, Max Reitz wrote:
Currently, when trying to create a backed image without specifying its
size, when the backing file does not exist or is not accessible, an
appropriate error message will be generated which is then (in
bdrv_img_create()) prefixed with the image file name and the strerror().
However, both are generally already part of the bdrv_open() error
message, so we should not double this information. An example:
$ qemu-img create -f qcow2 -b /tmp/enoent /tmp/img.qcow2
qemu-img: /tmp/img.qcow2: Could not open '/tmp/enoent': Could not open
'/tmp/enoent': No such file or directory: No such file or directory
Just propagating the error is sufficient:
$ qemu-img create -f qcow2 -b /tmp/enoent /tmp/img.qcow2
qemu-img /tmp/img.qcow2: Could not open '/tmp/enoent': No such file or
directory
Max Reitz (2):
block: Propagate error in bdrv_img_create()
iotests: Add test for non-existing backing file
block.c | 5 -----
tests/qemu-iotests/111 | 53 ++++++++++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/111.out | 3 +++
tests/qemu-iotests/group | 1 +
4 files changed, 57 insertions(+), 5 deletions(-)
create mode 100755 tests/qemu-iotests/111
create mode 100644 tests/qemu-iotests/111.out
Eric: Leaving "inexistent". It is in several dictionaries besides
Wiktionary :).
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Did you really? It appears neither there nor did it in your pull request...
Max
